http://codereview.chromium.org/6117003/diff/6/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right):
http://codereview.chromium.org/6117003/diff/6/src/arm/code-stubs-arm.cc#newcode977 src/arm/code-stubs-arm.cc:977: __ VFPCompareAndSetFlags(d7, d6, r0); No need to clear the flags, if the result is unordered the overflow flag will be set (the vs condition). http://codereview.chromium.org/6117003/diff/6/src/arm/code-stubs-arm.cc#newcode1097 src/arm/code-stubs-arm.cc:1097: __ VFPCompareAndSetFlags(d1, 0.0, scratch); Ditto. http://codereview.chromium.org/6117003/diff/6/src/arm/code-stubs-arm.cc#newcode4915 src/arm/code-stubs-arm.cc:4915: __ VFPCompareAndSetFlags(d0, d1, r2); Ditto. http://codereview.chromium.org/6117003/diff/6/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/6117003/diff/6/src/arm/macro-assembler-arm.cc#newcode531 src/arm/macro-assembler-arm.cc:531: void MacroAssembler::VFPCompareAndSetFlags(const DwVfpRegister src1, If the flags are cleared the intent is to read them shortly after, so the case where scratch is used sounds redundant with VFPCompareAndLoad. http://codereview.chromium.org/6117003/diff/6/src/arm/macro-assembler-arm.cc#newcode546 src/arm/macro-assembler-arm.cc:546: void MacroAssembler::VFPCompareAndSetFlags(const DwVfpRegister src1, Ditto. http://codereview.chromium.org/6117003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
