LGTM with the comments addressed.
-- Vitaly http://codereview.chromium.org/6686053/diff/12003/include/v8.h File include/v8.h (right): http://codereview.chromium.org/6686053/diff/12003/include/v8.h#newcode2727 include/v8.h:2727: static void AddImplicitRefGroup(Persistent<Object> parent, I don't like the name for two reasons: "Ref" is an abbreviation and there's no group here. As we discussed we should avoid any implications on the relations between children. "AddImplicitReferences", "AddImplicitChildren"? http://codereview.chromium.org/6686053/diff/12003/test/cctest/test-api.cc File test/cctest/test-api.cc (right): http://codereview.chromium.org/6686053/diff/12003/test/cctest/test-api.cc#newcode1847 test/cctest/test-api.cc:1847: V8::AddImplicitRefGroup(g2s2, g2_children, 1); It would be interesting to test longer chains of implicit references. http://codereview.chromium.org/6686053/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
