Florian, thanks for having a look!
When testing locally I see no differences in compilation time on average (as
reported by --hydrogen-stats).
Thanks,
Vitaly
http://codereview.chromium.org/6707001/diff/1/src/small-pointer-list.h
File src/small-pointer-list.h (right):
http://codereview.chromium.org/6707001/diff/1/src/small-pointer-list.h#newcode28
src/small-pointer-list.h:28: #ifndef V8_SMALL_POINTER_LIST_H_
On 2011/03/22 10:15:52, fschneider wrote:
You need to update the project files (gyp, visual studio, etc.) with
the new
file.
Updated.
http://codereview.chromium.org/6707001/diff/1/src/small-pointer-list.h#newcode89
src/small-pointer-list.h:89: if (pointer == single_value()) {
On 2011/03/22 10:15:52, fschneider wrote:
I rather like less nested if-statements:
if ((data_ & kTagMask) == kSingletonTag &&
pointer == single_value()) {
Can't combine them, because we need to return.
http://codereview.chromium.org/6707001/diff/1/src/small-pointer-list.h#newcode125
src/small-pointer-list.h:125: if (start == 0 && start <= end) {
On 2011/03/22 10:15:52, fschneider wrote:
Maybe a matter of taste - I prefer
if (start == 0 && end >= 0) {
here.
Done.
http://codereview.chromium.org/6707001/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
