LGTM!

http://codereview.chromium.org/6707001/diff/4001/src/small-pointer-list.h
File src/small-pointer-list.h (right):

http://codereview.chromium.org/6707001/diff/4001/src/small-pointer-list.h#newcode62
src/small-pointer-list.h:62: PointerList* list = new PointerList(2);
We should count the lengths of use lists that are >= 2.  This backing
store will be resized as soon as we add a another use.

If this is frequent, we should avoid the doubling and wasted 2-element
list and preallocate it a bit bigger.

http://codereview.chromium.org/6707001/diff/4001/src/small-pointer-list.h#newcode86
src/small-pointer-list.h:86: void RemoveElement(T* pointer) {
Maybe a short comment that the intended semantics is to remove if
present (like List::RemoveElement).

http://codereview.chromium.org/6707001/

--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev

Reply via email to