lgtm
http://codereview.chromium.org/7210057/diff/1/src/arm/assembler-arm.h File src/arm/assembler-arm.h (right): http://codereview.chromium.org/7210057/diff/1/src/arm/assembler-arm.h#newcode1229 src/arm/assembler-arm.h:1229: static int NumRegistersInRegList(RegList list); frames.h already has int NumRegs(RegList list) http://codereview.chromium.org/7210057/diff/1/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/7210057/diff/1/src/arm/stub-cache-arm.cc#newcode72 src/arm/stub-cache-arm.cc:72: value_off_addr - key_off_addr)); Strange indentation here. The value_off_addr should line up with the offsets_base_addr. Alternatively the MemOperand should line up with the scratch2. http://codereview.chromium.org/7210057/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
