Drive by comments.
http://codereview.chromium.org/7210057/diff/1/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/7210057/diff/1/src/ia32/stub-cache-ia32.cc#newcode171 src/ia32/stub-cache-ia32.cc:171: USE(extra2); // The register extra2 is not used on the ia32 platform. Will a USE(extra3) be needed to compile in release mode? http://codereview.chromium.org/7210057/diff/1/src/ia32/stub-cache-ia32.cc#newcode188 src/ia32/stub-cache-ia32.cc:188: ASSERT(!scratch.is(no_reg)); Also assert that extra is not no_reg? http://codereview.chromium.org/7210057/diff/1/src/x64/stub-cache-x64.cc File src/x64/stub-cache-x64.cc (right): http://codereview.chromium.org/7210057/diff/1/src/x64/stub-cache-x64.cc#newcode162 src/x64/stub-cache-x64.cc:162: ASSERT(!scratch.is(no_reg)); Also assert that extra is no_reg? http://codereview.chromium.org/7210057/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
