LGTM with comments addressed.
http://codereview.chromium.org/7660016/diff/1/src/isolate.cc File src/isolate.cc (right): http://codereview.chromium.org/7660016/diff/1/src/isolate.cc#newcode1594 src/isolate.cc:1594: if (external_reference_table_ != NULL) { It's safe to delete NULL. "if" is not necessary. http://codereview.chromium.org/7660016/diff/1/src/zone.cc File src/zone.cc (right): http://codereview.chromium.org/7660016/diff/1/src/zone.cc#newcode82 src/zone.cc:82: delete segment_head_; This should use DeleteSegment. http://codereview.chromium.org/7660016/diff/1/src/zone.h File src/zone.h (right): http://codereview.chromium.org/7660016/diff/1/src/zone.h#newcode61 src/zone.h:61: ~Zone(); Given that the constructor is private it makes sense to have the destructor private too (if possible). http://codereview.chromium.org/7660016/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
