Comments addressed, landing.
http://codereview.chromium.org/7660016/diff/1/src/isolate.cc File src/isolate.cc (right): http://codereview.chromium.org/7660016/diff/1/src/isolate.cc#newcode1594 src/isolate.cc:1594: if (external_reference_table_ != NULL) { On 2011/08/16 17:52:32, Vitaly Repeshko wrote:
It's safe to delete NULL. "if" is not necessary.
Done. http://codereview.chromium.org/7660016/diff/1/src/zone.cc File src/zone.cc (right): http://codereview.chromium.org/7660016/diff/1/src/zone.cc#newcode82 src/zone.cc:82: delete segment_head_; On 2011/08/16 17:52:32, Vitaly Repeshko wrote:
This should use DeleteSegment.
Done. This required putting the code into a separate method, because DeleteSegment() depends on the isolate's counters being alive, but at the time ~Zone() runs they're already deleted. http://codereview.chromium.org/7660016/diff/1/src/zone.h File src/zone.h (right): http://codereview.chromium.org/7660016/diff/1/src/zone.h#newcode61 src/zone.h:61: ~Zone(); On 2011/08/16 17:52:32, Vitaly Repeshko wrote:
Given that the constructor is private it makes sense to have the
destructor
private too (if possible).
Done. http://codereview.chromium.org/7660016/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
