Reviewers: Mikhail Naganov (Chromium),
Description:
Inline the implementation of Handle default ctor.
BUG=None
TEST=None
[email protected]
Signed-off-by: Thiago Farina <[email protected]>
Please review this at http://codereview.chromium.org/7669013/
SVN Base: git://github.com/v8/v8.git@master
Affected files:
M include/v8.h
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index
d1bceca3f63f421e67e1af0e0c890bec56edfdab..e722d34e67762566bd3f65acfd3f5b02b35f53ac
100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -171,12 +171,12 @@ template <class T> class Handle {
/**
* Creates an empty handle.
*/
- inline Handle();
+ inline Handle() : val_(0) {}
/**
* Creates a new handle for the specified value.
*/
- inline explicit Handle(T* val) : val_(val) { }
+ inline explicit Handle(T* val) : val_(val) {}
/**
* Creates a handle for the contents of the specified handle. This
@@ -203,14 +203,14 @@ template <class T> class Handle {
*/
inline bool IsEmpty() const { return val_ == 0; }
- inline T* operator->() const { return val_; }
-
- inline T* operator*() const { return val_; }
-
/**
* Sets the handle to be empty. IsEmpty() will then return true.
*/
- inline void Clear() { this->val_ = 0; }
+ inline void Clear() { val_ = 0; }
+
+ inline T* operator->() const { return val_; }
+
+ inline T* operator*() const { return val_; }
/**
* Checks whether two handles are the same.
@@ -3827,10 +3827,6 @@ class Internals {
template <class T>
-Handle<T>::Handle() : val_(0) { }
-
-
-template <class T>
Local<T>::Local() : Handle<T>() { }
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
