LGTM, what about calls from freeze and preventextension, the error message
seems
wrong in this case. In addition, we should have test cases for them as well.
http://codereview.chromium.org/7858031/diff/1001/test/mjsunit/regress/regress-95920.js
File test/mjsunit/regress/regress-95920.js (right):
http://codereview.chromium.org/7858031/diff/1001/test/mjsunit/regress/regress-95920.js#newcode33
test/mjsunit/regress/regress-95920.js:33: [0].every(function(){
Object.seal((new Int8Array(42))); });
assertThrows?
http://codereview.chromium.org/7858031/diff/1001/test/mjsunit/regress/regress-95920.js#newcode34
test/mjsunit/regress/regress-95920.js:34: assertTrue(false); // Should
be unreachable
assertUnreachable?
http://codereview.chromium.org/7858031/diff/1001/test/mjsunit/regress/regress-95920.js#newcode41
test/mjsunit/regress/regress-95920.js:41: defineProperty(new
Int8Array(42), "1", { writable: false, value: "1" });
same as above
http://codereview.chromium.org/7858031/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
