Revision: 9213
Author: [email protected]
Date: Fri Sep 9 07:30:00 2011
Log: Don't allow seal or element property re-definition on external
arrays.
[email protected]
BUG=95920
TEST=test/mjsunit/regress/regress-95920.js
Review URL: http://codereview.chromium.org/7858031
http://code.google.com/p/v8/source/detail?r=9213
Added:
/branches/bleeding_edge/test/mjsunit/regress/regress-95920.js
Modified:
/branches/bleeding_edge/src/messages.js
/branches/bleeding_edge/src/objects.cc
/branches/bleeding_edge/src/runtime.cc
=======================================
--- /dev/null
+++ /branches/bleeding_edge/test/mjsunit/regress/regress-95920.js Fri Sep
9 07:30:00 2011
@@ -0,0 +1,58 @@
+// Copyright 2011 the V8 project authors. All rights reserved.
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+// * Redistributions of source code must retain the above copyright
+// notice, this list of conditions and the following disclaimer.
+// * Redistributions in binary form must reproduce the above
+// copyright notice, this list of conditions and the following
+// disclaimer in the documentation and/or other materials provided
+// with the distribution.
+// * Neither the name of Google Inc. nor the names of its
+// contributors may be used to endorse or promote products derived
+// from this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+// Tests that objects with external arrays cannot be sealed or have their
+// properties redefined.
+
+(function() {
+ assertThrows(function() {
+ [0].every(function(){ Object.seal((new Int8Array(42))); });
+ assertUnreable();
+ }, TypeError)
+})();
+
+(function() {
+ assertThrows(function() {
+ [0].every(function(){ Object.freeze((new Int8Array(42))); });
+ assertUnreable();
+ }, TypeError)
+})();
+
+(function() {
+ assertThrows(function() {
+ [0].every(function(){ Object.preventExtensions((new Int8Array(42)));
});
+ assertUnreable();
+ }, TypeError)
+})();
+
+(function() {
+ assertThrows(function() {
+ Object.defineProperty(new Int8Array(42), "1",
+ { writable: false, value: "1" });
+ assertUnreable();
+ })
+})();
=======================================
--- /branches/bleeding_edge/src/messages.js Mon Sep 5 00:30:35 2011
+++ /branches/bleeding_edge/src/messages.js Fri Sep 9 07:30:00 2011
@@ -239,6 +239,8 @@
"strict_poison_pill", ["'caller', 'callee',
and 'arguments' properties may not be accessed on strict mode functions or
the arguments objects for calls to them"],
"strict_caller", ["Illegal access to a strict mode
caller function."],
"unprotected_let", ["Illegal let declaration in
unprotected statement context."],
+ "cant_prevent_ext_external_array_elements", ["Cannot prevent
extension of an object with external array elements"],
+ "redef_external_array_element", ["Cannot redefine a property of an
object with external array elements"],
];
var messages = { __proto__ : null };
var desc = new PropertyDescriptor();
=======================================
--- /branches/bleeding_edge/src/objects.cc Fri Sep 9 02:35:57 2011
+++ /branches/bleeding_edge/src/objects.cc Fri Sep 9 07:30:00 2011
@@ -3413,6 +3413,17 @@
ASSERT(proto->IsJSGlobalObject());
return JSObject::cast(proto)->PreventExtensions();
}
+
+ // It's not possible to seal objects with external array elements
+ if (HasExternalArrayElements()) {
+ HandleScope scope(isolate);
+ Handle<Object> object(this);
+ Handle<Object> error =
+ isolate->factory()->NewTypeError(
+ "cant_prevent_ext_external_array_elements",
+ HandleVector(&object, 1));
+ return isolate->Throw(*error);
+ }
// If there are fast elements we normalize.
NumberDictionary* dictionary = NULL;
=======================================
--- /branches/bleeding_edge/src/runtime.cc Fri Sep 9 02:35:57 2011
+++ /branches/bleeding_edge/src/runtime.cc Fri Sep 9 07:30:00 2011
@@ -4293,6 +4293,17 @@
if (proto->IsNull()) return *obj_value;
js_object = Handle<JSObject>::cast(proto);
}
+
+ // Don't allow element properties to be redefined on objects with
external
+ // array elements.
+ if (js_object->HasExternalArrayElements()) {
+ Handle<Object> args[2] = { js_object, name };
+ Handle<Object> error =
+ isolate->factory()->NewTypeError("redef_external_array_element",
+ HandleVector(args, 2));
+ return isolate->Throw(*error);
+ }
+
Handle<NumberDictionary> dictionary = NormalizeElements(js_object);
// Make sure that we never go back to fast case.
dictionary->set_requires_slow_elements();
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
