LGTM, platform specific comments in arm is also valid for ia32 and x64
http://codereview.chromium.org/8256015/diff/2002/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): http://codereview.chromium.org/8256015/diff/2002/src/arm/full-codegen-arm.cc#newcode1023 src/arm/full-codegen-arm.cc:1023: __ mov(r1, Operand(Smi::FromInt(1))); // smi indicates slow check Capitalize start of comment + below http://codereview.chromium.org/8256015/diff/2002/src/arm/full-codegen-arm.cc#newcode1030 src/arm/full-codegen-arm.cc:1030: __ Push(r1, r0); // map or smi, and array how can r1 be a map, we either load smi 1 or smi 0 above right? http://codereview.chromium.org/8256015/diff/2002/src/arm/full-codegen-arm.cc#newcode1060 src/arm/full-codegen-arm.cc:1060: // TODO(rossberg): What if only a prototype is a proxy? Not specified. Please file a bug http://codereview.chromium.org/8256015/diff/2002/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): http://codereview.chromium.org/8256015/diff/2002/src/ia32/full-codegen-ia32.cc#newcode1014 src/ia32/full-codegen-ia32.cc:1014: __ push(eax); Add comment about what eax is http://codereview.chromium.org/8256015/diff/2002/src/v8natives.js File src/v8natives.js (right): http://codereview.chromium.org/8256015/diff/2002/src/v8natives.js#newcode887 src/v8natives.js:887: var names = {} // TODO(rossberg): use sets once they are ready. Please file bug http://codereview.chromium.org/8256015/diff/2002/src/v8natives.js#newcode1013 src/v8natives.js:1013: global.print("GetOwnEnumerablePropertyNames"); Debug print? http://codereview.chromium.org/8256015/diff/2002/src/x64/full-codegen-x64.cc File src/x64/full-codegen-x64.cc (right): http://codereview.chromium.org/8256015/diff/2002/src/x64/full-codegen-x64.cc#newcode989 src/x64/full-codegen-x64.cc:989: __ push(rax); Add comment about what rax is http://codereview.chromium.org/8256015/diff/2002/test/mjsunit/harmony/proxies-for.js File test/mjsunit/harmony/proxies-for.js (right): http://codereview.chromium.org/8256015/diff/2002/test/mjsunit/harmony/proxies-for.js#newcode28 test/mjsunit/harmony/proxies-for.js:28: // Flags: --harmony-proxies General in this file: Add semicolons http://codereview.chromium.org/8256015/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
