http://codereview.chromium.org/8373029/diff/47027/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/8373029/diff/47027/src/x64/lithium-codegen-x64.cc#newcode1688
src/x64/lithium-codegen-x64.cc:1688: __ CmpObjectType(input,
FIRST_NONSTRING_TYPE, rcx);
Here you need to use a temp register like on the other platforms.

You could also use IsObjectTypeString like on ia32.

http://codereview.chromium.org/8373029/diff/47027/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):

http://codereview.chromium.org/8373029/diff/47027/src/x64/lithium-x64.cc#newcode1410
src/x64/lithium-x64.cc:1410: return
AssignEnvironment(MarkAsCall(DefineFixed(result, rax), instr));
Remove this call to AssignEnvironment.

http://codereview.chromium.org/8373029/diff/47027/src/x64/lithium-x64.cc#newcode1469
src/x64/lithium-x64.cc:1469:
ASSERT(instr->value()->representation().IsTagged());
You need to allocate a temp register using TempRegister() like on the
other platforms.

http://codereview.chromium.org/8373029/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to