No worry, we have not forgot about the issue. And yes, I also agree about test coverage. Please add more tests so we can land it now. It will also help testing when adding future improvements to the switch statement.
--Florian Den 8. nov. 2011 19.06 skrev Fedor Indutny <[email protected]>: > Agreed. > > Is it blocking landing of current version of patch? > > Cheers, > Fedor. > > > > On Tue, Nov 8, 2011 at 6:07 PM, Vyacheslav Egorov <[email protected]>wrote: > >> We need to increase the coverage of the switch test for different >> switch use cases (string, smi, mixed), different inputs (symbol >> strings, non-symbol strings, oddballs, smis, heap numbers), different >> state of switch (optimized, non-optimized, optimized code >> deoptimizing), different levels of type feedback coverage of the >> switch statement (none cases have typefeedback, all cases have >> typefeedback, "target" case has typefeedback, target case does not >> have typefeedback). >> >> -- >> Vyacheslav Egorov >> >> >> On Tue, Nov 8, 2011 at 11:46 AM, <[email protected]> wrote: >> > fixed, thanks >> > >> > http://codereview.chromium.org/8373029/ >> > >> > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
