http://codereview.chromium.org/8825003/diff/3001/src/mksnapshot.cc File src/mksnapshot.cc (right):
http://codereview.chromium.org/8825003/diff/3001/src/mksnapshot.cc#newcode112 src/mksnapshot.cc:112: fprintf(fp, "%d", at(j)); Instead of using unsigned char you can probably just add a cast from char to unsigned char here. This will be a smaller yet more correct change (as it conveys our intent directly --- we want all printed values to be positive). What do you think? http://codereview.chromium.org/8825003/diff/3001/src/mksnapshot.cc#newcode237 src/mksnapshot.cc:237: output_ = new i::ScopedVector<unsigned char>((input.length() * 101) / 100 Usually we are leaving operation on the previous line. You can break the line after >( if + does not fit. http://codereview.chromium.org/8825003/diff/3001/test/cctest/test-regexp.cc File test/cctest/test-regexp.cc (right): http://codereview.chromium.org/8825003/diff/3001/test/cctest/test-regexp.cc#newcode840 test/cctest/test-regexp.cc:840: const_cast<uc16>('\xa0')}; Why do you need const_cast here? const_cast is for changing constness not type. http://codereview.chromium.org/8825003/diff/3001/test/cctest/test-regexp.cc#newcode861 test/cctest/test-regexp.cc:861: const_cast<uc16>('\xa0')}; Ditto. http://codereview.chromium.org/8825003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
