Review fixes: - Only a cast for printf - Use static_cast instead of const_cast - Add entry to AUTHORS
http://codereview.chromium.org/8825003/diff/3001/src/mksnapshot.cc File src/mksnapshot.cc (right): http://codereview.chromium.org/8825003/diff/3001/src/mksnapshot.cc#newcode112 src/mksnapshot.cc:112: fprintf(fp, "%d", at(j)); On 2011/12/12 18:06:17, Vyacheslav Egorov wrote:
you can probably just add a cast from char to unsigned char here. This will be a smaller yet more correct change (as it conveys our intent directly
I agree that the patch will be shorter. I am not sure that it is more correct. With the current patch, no cast is needed which I regard as more correct than adding a cast. However, I am open for either solution. http://codereview.chromium.org/8825003/diff/3001/test/cctest/test-regexp.cc File test/cctest/test-regexp.cc (right): http://codereview.chromium.org/8825003/diff/3001/test/cctest/test-regexp.cc#newcode840 test/cctest/test-regexp.cc:840: const_cast<uc16>('\xa0')}; On 2011/12/12 18:06:17, Vyacheslav Egorov wrote:
Why do you need const_cast here? const_cast is for changing constness not type.
True, a static_cast should be sufficient. (In the patch description I actually claimed that I were using a static_cast.) http://codereview.chromium.org/8825003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
