I think the whole code for matching against FLAG_hydrogen_stats should be
moved
into a separate function and this should be used everywhere instead of
direct
accesses to this flag, something like
bool MatchAgainstHydrogenFilter(Handle<string> name)
This can handle the normal/inverted logic consistently.
https://chromiumcodereview.appspot.com/9691042/diff/1/src/compiler.cc
File src/compiler.cc (right):
https://chromiumcodereview.appspot.com/9691042/diff/1/src/compiler.cc#newcode248
src/compiler.cc:248: if (*FLAG_hydrogen_filter) {
If this is allowed, I'll immediately start writing 'if (ptr) ...' for
ptr being an expression with a pointer type (something I really like,
but which is forbidden under Google law, I think). :-)
https://chromiumcodereview.appspot.com/9691042/diff/1/src/compiler.cc#newcode250
src/compiler.cc:250: ASSERT(!filter.is_empty());
I don't think we need this assertion when the corresponding test is 2
lines above.
https://chromiumcodereview.appspot.com/9691042/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
