The hydrogen-filter flag should not be used anywhere else. I removed the
filter
from the PrintCode function since it should only concern which function gets
optimized, not which code gets printed.
https://chromiumcodereview.appspot.com/9691042/diff/1/src/compiler.cc
File src/compiler.cc (right):
https://chromiumcodereview.appspot.com/9691042/diff/1/src/compiler.cc#newcode248
src/compiler.cc:248: if (*FLAG_hydrogen_filter) {
On 2012/03/14 07:35:36, Sven Panne wrote:
If this is allowed, I'll immediately start writing 'if (ptr) ...' for
ptr being
an expression with a pointer type (something I really like, but which
is
forbidden under Google law, I think). :-)
I don't know about that, but I can compare it to \0 instead.
https://chromiumcodereview.appspot.com/9691042/diff/1/src/compiler.cc#newcode250
src/compiler.cc:250: ASSERT(!filter.is_empty());
On 2012/03/14 07:35:36, Sven Panne wrote:
I don't think we need this assertion when the corresponding test is 2
lines
above.
Done.
https://chromiumcodereview.appspot.com/9691042/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
