On 2012/04/12 14:55:23, alexeif wrote:

https://chromiumcodereview.appspot.com/10049002/diff/14003/src/profile-generator.cc
File src/profile-generator.cc (right):


https://chromiumcodereview.appspot.com/10049002/diff/14003/src/profile-generator.cc#newcode1435
src/profile-generator.cc:1435: int entries = 0;
never used?

done



https://chromiumcodereview.appspot.com/10049002/diff/14003/src/profile-generator.cc#newcode1456
src/profile-generator.cc:1456: uint32_t entries_count = 0;
move it inside the loop.

done



https://chromiumcodereview.appspot.com/10049002/diff/14003/src/profile-generator.cc#newcode1463
src/profile-generator.cc:1463: ++entries_count;
you can eliminate this ++. just calc the difference between end and start
entry_info.

I've a plan to calculate the size of the objects. That's why I have to iterate
over all the entries.

https://chromiumcodereview.appspot.com/10049002/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to