LGTM
https://chromiumcodereview.appspot.com/10049002/diff/16002/test/cctest/test-heap-profiler.cc File test/cctest/test-heap-profiler.cc (right): https://chromiumcodereview.appspot.com/10049002/diff/16002/test/cctest/test-heap-profiler.cc#newcode812 test/cctest/test-heap-profiler.cc:812: TestStatsStream stats_update = GetHeapStatsUpdate(); nit: Might be worth adding a comment that prior to getting an update GC is called, so previously added strings must be collected. Otherwise one needs to get to the implementation in order to understand this. https://chromiumcodereview.appspot.com/10049002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
