lgtm
http://codereview.chromium.org/10872084/diff/1/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/10872084/diff/1/src/objects.cc#newcode12005 src/objects.cc:12005: reinterpret_cast<CompilationCacheTable*>(obj); Do we really need the reinterpret_cast here or would CompilationCacheTable::cast work, too? If the latter works, using a templatized To would be better (probably below, too, but there it doesn't really make a difference). Another point: Removing the tiny scopes is a bad idea IMHO, one should keep the scopes/lifetimes as small as possible to help readability. Furthermore, the tiny scopes are a common v8 idiom. http://codereview.chromium.org/10872084/diff/1/src/parser.cc File src/parser.cc (right): http://codereview.chromium.org/10872084/diff/1/src/parser.cc#newcode1805 src/parser.cc:1805: (mode != VAR && mode != CONST) || o_O http://codereview.chromium.org/10872084/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
