https://chromiumcodereview.appspot.com/10872084/diff/1/src/objects.cc File src/objects.cc (right):
https://chromiumcodereview.appspot.com/10872084/diff/1/src/objects.cc#newcode12005 src/objects.cc:12005: reinterpret_cast<CompilationCacheTable*>(obj); On 2012/08/28 07:35:00, Sven Panne wrote:
Do we really need the reinterpret_cast here or would
CompilationCacheTable::cast
work, too? If the latter works, using a templatized To would be better
(probably
below, too, but there it doesn't really make a difference).
Indeed, it's not needed. Changed.
Another point: Removing the tiny scopes is a bad idea IMHO, one should
keep the
scopes/lifetimes as small as possible to help readability.
Furthermore, the tiny
scopes are a common v8 idiom.
Yeah, in principle, I agree with you. Except that in C++, I have been so conditioned to have all flags go up when I encounter a scope like that that I find seeing one where no RAII hack is in play more irritating than helpful... ;) https://chromiumcodereview.appspot.com/10872084/diff/1/src/parser.cc File src/parser.cc (right): https://chromiumcodereview.appspot.com/10872084/diff/1/src/parser.cc#newcode1805 src/parser.cc:1805: (mode != VAR && mode != CONST) || On 2012/08/28 07:35:00, Sven Panne wrote:
o_O
You gotta love the beauty of semantic incoherence and backwards compatibility hacks in our all's favorite language. https://chromiumcodereview.appspot.com/10872084/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
