LGTM with a nit, which applies to all 4 versions of DoStoreKeyed. Let's not
make
C++ even more verbose that it already is... ;-)
https://codereview.chromium.org/11412129/diff/3001/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
https://codereview.chromium.org/11412129/diff/3001/src/arm/lithium-arm.cc#newcode1959
src/arm/lithium-arm.cc:1959: result = new(zone()) LStoreKeyed(object,
key, val);
Directly returning here and below without any temp variable is shorter
and actually clearer, I think. No confusing declaration, no
initialization and no assertion. :-)
https://codereview.chromium.org/11412129/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
