Thanks Sven, I updated the files for early return, and visited the ia32 file in
the same way.

https://codereview.chromium.org/11412129/diff/3001/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):

https://codereview.chromium.org/11412129/diff/3001/src/arm/lithium-arm.cc#newcode1959
src/arm/lithium-arm.cc:1959: result = new(zone()) LStoreKeyed(object,
key, val);
On 2012/11/21 13:30:51, Sven Panne wrote:
Directly returning here and below without any temp variable is shorter
and
actually clearer, I think. No confusing declaration, no initialization
and no
assertion. :-)

Thanks, that is true! I've adjusted the ia32 file as well because it is
similar.

https://codereview.chromium.org/11412129/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to