Just a single quick drive-by comment. Apart from this, I would be
interested in
the use case for the new API entries, it is not immediately obvious, at
least
not for me. :-)
https://codereview.chromium.org/11142013/diff/10001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/11142013/diff/10001/include/v8.h#newcode3424
include/v8.h:3424: static void ResumeExecution(Isolate* isolate = NULL);
In general, we are moving into the direction of requiring Isolate
parameters when the implementation of the API function needs an Isolate.
So I would very much prefer making the parameter non-optional and avoid
introducing yet another old-style API entry.
https://codereview.chromium.org/11142013/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
