Is there any way I can see the log of the failure? I'll boot up a vm and see if I can track it down in the meantime.
-Andrew On Thu, Dec 13, 2012 at 12:20 PM, Yang Guo <[email protected]> wrote: > Hi Andrew, > > I landed your patch for a short while, but the tests fail on windows debug > builds. I will take a look what's going on there, but i won't be able to do > that until Monday. So I'm reverting it for now. > > Yang > > > On Thu, Dec 13, 2012 at 5:21 PM, Yang Guo <[email protected]> wrote: > >> Hi Andrew, >> >> I got word that it arrived, but the list hasn't been updated just yet. >> I'll land your patch in a moment. >> >> Yang >> >> >> On Thu, Dec 13, 2012 at 4:56 PM, <[email protected]> wrote: >> >>> I'm employed by Bloomberg but my open-source work is done under my >>> personal >>> e-mail address. I e-mailed the signed corp CLA .pdf to >>> [email protected] yesterday at 2PM. I suppose there is some >>> delay until >>> it shows wherever you are looking? >>> >>> -Andrew >>> >>> >>> On 2012/12/13 15:51:00, Yang wrote: >>> >>>> On 2012/12/13 02:20:43, apaprocki wrote: >>>> > Updated the patch according to comments. >>>> > >>>> > Rather than duplicate the guts of StackGuard::Continue() inside >>>> > StackGuard::ResumeExecution(), I just call Continue(TERMINATE) there >>>> instead >>>> > since the ExecutionAccess guard is recursive. >>>> > >>>> > The TERMINATE flag must be cleared at this point so that when >>>> > Execution::**HandleStackGuardInterrupt() runs, >>>> stack_guard->**IsTerminateException() >>>> > returns false. >>>> >>> >>> LGTM. But before I land this, I'd like to clear up one thing: what is >>>> the >>>> affiliation with Bloomberg Finance L.P.? I have checked and don't see >>>> >>> Bloomberg >>> >>>> Finance L.P. registered as have signed the corporate CLA. You however >>>> are, >>>> registered as individual. I'm sort of confused. >>>> >>> >>> >>> >>> https://codereview.chromium.**org/11142013/<https://codereview.chromium.org/11142013/> >>> >> >> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
