https://codereview.chromium.org/11195045/diff/9001/src/platform-linux.cc File src/platform-linux.cc (right):
https://codereview.chromium.org/11195045/diff/9001/src/platform-linux.cc#newcode1073 src/platform-linux.cc:1073: if (signal_handler_installed_ && old_signal_handler_.sa_sigaction) Go ahead and re-open this one, since I'd like to make sure that all of the knowledge how to fix this including Markus' comments are in one place. After what he wrote, however, I feel completely unqualified to review this patch. :-) On 2012/12/12 22:28:37, willchan wrote:
old_signal_handler_.sa_sigaction is 0x1 in the crash. Apparently this
is the
magic value SIG_IGN or something. I'm adding markus@ to the code
review so he
can educate me on what I'm actually supposed to be doing here to make
V8's
SIGPROF handler and TCMalloc's SIGPROF handler play nice. Then I'll
fix this.
danno/v8-dev: Should I reopen this issue and upload new patches here?
Or should
I open a new issue?
https://codereview.chromium.org/11195045/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
