https://codereview.chromium.org/11195045/diff/18002/src/platform-linux.cc File src/platform-linux.cc (right):
https://codereview.chromium.org/11195045/diff/18002/src/platform-linux.cc#newcode1036 src/platform-linux.cc:1036: static void ProfilerSignalHandler(int signal, siginfo_t* info, void* context); Ah, sanity prevails. And yes, I agree that the preference in the Chrome style guide seems somewhat arbitrary :-) On 2012/12/13 09:34:54, Sven Panne wrote:
On 2012/12/13 08:49:45, Markus (顧孟勤) wrote: > Our style guide for some reason prefers that we don't mark symbols
as static.
> Instead, we should put them into an anonymous namespace. [...]
The Google C++ style guide allows both possibilities and does not even
give a
preference to one of them. The Chrome style guide (which we don't
follow at all
;-) seems to prefer unnamed namespaces, but I don't understand the
reasoning
behind it: At least on Linux the end result seems to be the same.
But to make things short: Just leave "static" here, we use it all over
the place
in v8.
https://codereview.chromium.org/11195045/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
