LGTM with comments.
https://codereview.chromium.org/11684005/diff/8001/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): https://codereview.chromium.org/11684005/diff/8001/src/ia32/macro-assembler-ia32.cc#newcode1266 src/ia32/macro-assembler-ia32.cc:1266: if ((flags & DOUBLE_ALIGNMENT) != 0) { Maybe add an assert saying that this works because kPointerAlignment * 2 == kDoubleAlignment https://codereview.chromium.org/11684005/diff/8001/src/ia32/macro-assembler-ia32.cc#newcode1358 src/ia32/macro-assembler-ia32.cc:1358: STATIC_ASSERT(static_cast<ScaleFactor>(times_8 - 1) == times_4); Also assert that kSmiTagSize == 1. https://codereview.chromium.org/11684005/diff/8001/src/x64/macro-assembler-x64.cc File src/x64/macro-assembler-x64.cc (right): https://codereview.chromium.org/11684005/diff/8001/src/x64/macro-assembler-x64.cc#newcode3784 src/x64/macro-assembler-x64.cc:3784: Label aligned; You can use MacroAssembler::Check for this. https://codereview.chromium.org/11684005/diff/8001/src/x64/macro-assembler-x64.cc#newcode3854 src/x64/macro-assembler-x64.cc:3854: Label aligned; Ditto. https://codereview.chromium.org/11684005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
