Feedback addresses.
https://chromiumcodereview.appspot.com/11684005/diff/8001/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): https://chromiumcodereview.appspot.com/11684005/diff/8001/src/ia32/macro-assembler-ia32.cc#newcode1266 src/ia32/macro-assembler-ia32.cc:1266: if ((flags & DOUBLE_ALIGNMENT) != 0) { On 2012/12/28 10:03:48, Yang wrote:
Maybe add an assert saying that this works because kPointerAlignment *
2 ==
kDoubleAlignment
Done. https://chromiumcodereview.appspot.com/11684005/diff/8001/src/ia32/macro-assembler-ia32.cc#newcode1358 src/ia32/macro-assembler-ia32.cc:1358: STATIC_ASSERT(static_cast<ScaleFactor>(times_8 - 1) == times_4); On 2012/12/28 10:03:48, Yang wrote:
Also assert that kSmiTagSize == 1.
Done. https://chromiumcodereview.appspot.com/11684005/diff/8001/src/x64/macro-assembler-x64.cc File src/x64/macro-assembler-x64.cc (right): https://chromiumcodereview.appspot.com/11684005/diff/8001/src/x64/macro-assembler-x64.cc#newcode3784 src/x64/macro-assembler-x64.cc:3784: Label aligned; On 2012/12/28 10:03:48, Yang wrote:
You can use MacroAssembler::Check for this.
Done. https://chromiumcodereview.appspot.com/11684005/diff/8001/src/x64/macro-assembler-x64.cc#newcode3854 src/x64/macro-assembler-x64.cc:3854: Label aligned; On 2012/12/28 10:03:48, Yang wrote:
Ditto.
Done. https://chromiumcodereview.appspot.com/11684005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
