lgtm. It looks like you can use CmpHeapObject in another place in 32 bit as
well, and it might be good to expose the method in all platforms (though I
know
ARM doesn't have some of these register micro-optimizations).
https://codereview.chromium.org/15779004/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/15779004/diff/1/src/x64/lithium-codegen-x64.cc#newcode4958
src/x64/lithium-codegen-x64.cc:4958: __ CmpHeapObject(reg, target);
Nice that you could refactor this code...how about the one in 32bit
though? I see it in ARM too (lithium-codegen-arm.cc)
https://codereview.chromium.org/15779004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
