Landing ...
https://codereview.chromium.org/15779004/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/15779004/diff/1/src/x64/lithium-codegen-x64.cc#newcode4958
src/x64/lithium-codegen-x64.cc:4958: __ CmpHeapObject(reg, target);
On 2013/05/23 13:09:14, mvstanton wrote:
Nice that you could refactor this code...how about the one in 32bit
though? I
see it in ARM too (lithium-codegen-arm.cc)
As discussed offline: Yes, I agree, ia32 should use the same pattern,
but it currently decides at LChunkBuilder time. And with parallel
compilation the location might change. This should be cleaned up as
well. As for ARM, the bug doesn't exists there so that's also up for a
follow-up CL, this should be kept a clean bug-fix.
https://codereview.chromium.org/15779004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
