"webkit" would definitely be a better name for this test suite than "blink".
After all, these are tests that the Blink project inherited from WebKit and is
now trying to get rid of.


https://codereview.chromium.org/17260002/diff/1/test/blink/blink.status
File test/blink/blink.status (right):

https://codereview.chromium.org/17260002/diff/1/test/blink/blink.status#newcode28
test/blink/blink.status:28: prefix blink
This line is not needed.

https://codereview.chromium.org/17260002/diff/1/test/blink/blink.status2
File test/blink/blink.status2 (right):

https://codereview.chromium.org/17260002/diff/1/test/blink/blink.status2#newcode28
test/blink/blink.status2:28: []
This entire file is not needed. It is auto-generated on demand from the
.status equivalent.

https://codereview.chromium.org/17260002/diff/1/test/blink/testcfg.py
File test/blink/testcfg.py (right):

https://codereview.chromium.org/17260002/diff/1/test/blink/testcfg.py#newcode51
test/blink/testcfg.py:51: dirs.sort()
I think you want to filter the "resources" directory here.

https://codereview.chromium.org/17260002/diff/1/test/blink/testcfg.py#newcode109
test/blink/testcfg.py:109: if not line.strip(): continue
To make this test suite pass on Android and NaCl, you'll also have to
filter the actual output lines we ignore for the "messages" test suite.

https://codereview.chromium.org/17260002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to