https://chromiumcodereview.appspot.com/17260002/diff/15001/test/webkit/testcfg.py#newcode52
test/webkit/testcfg.py:52: if dirname == exclude:
I guess this works, but it doesn't fit with the exclusion scheme used
right
above. How about:
exclude = 'resources'
if exclude in dirs:
dirs.remove(exclude)
That way we won't even visit the 'resources' directory.
Or you could modify/extend the existing filter:
for excluded in [x for x in dirs if x.startswith('.') or x
== 'resources']:
dirs.remove(excluded)
With both suggested ways, we would ignore _every_ subdir
called 'resources'. If
the test suite grows, there could be a subdir for 'resource' tests somewhere
called special_tests/resources, which we would also ignore. But we only
want to
ignore the exact dir <test root>/resources and its subdirs. I agree that
this
kind of filter looks awkward - I'd rather prefer a first-class filter object
that is assigned to the tree-walker instead of these conditions. But I
could not
find a nice python way of doing that...
https://chromiumcodereview.appspot.com/17260002/diff/15001/test/webkit/testcfg.py#newcode122
test/webkit/testcfg.py:122: if line.startswith("#") or not line.strip():
continue
Don't you need to have this line in ActIterator too to filter out the
copyright
headers?
No - the test cases don't print out the license header.
https://codereview.chromium.org/17260002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
