PTAL
https://codereview.chromium.org/18587007/diff/1/src/types.cc
File src/types.cc (right):
https://codereview.chromium.org/18587007/diff/1/src/types.cc#newcode501
src/types.cc:501: for (int i = 0; i < unioned->length(); ++i) {
On 2013/07/03 14:52:54, rossberg wrote:
Note that for a union, at most one part is not a constant
or class. Since you do
not print any information to distinguish either of those
anyway, it might make
sense to just print a summary NumClasses and NumConstants
for a union, plus the
bitset part if present.
As discussed offline, i now print the addresses of those elements, so
its again usefull to keep them in the output
https://codereview.chromium.org/18587007/diff/1/src/types.h
File src/types.h (right):
https://codereview.chromium.org/18587007/diff/1/src/types.h#newcode231
src/types.h:231: PRIMITIVE_TYPE_LIST(DECLARE_PRIMITIVE_TYPE)
On 2013/07/03 14:52:54, rossberg wrote:
Nit: maybe indent this by 2
i'd rather not, since it looks very strange if the defined macro goes
over multiple lines.
https://codereview.chromium.org/18587007/diff/1/src/types.h#newcode233
src/types.h:233: kUnusedEOL = 0
On 2013/07/03 14:52:54, rossberg wrote:
What's that for?
you cannot end the enum definition with a comma...
https://codereview.chromium.org/18587007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
