LGTM with comments
https://codereview.chromium.org/18587007/diff/23001/src/types.cc
File src/types.cc (right):
https://codereview.chromium.org/18587007/diff/23001/src/types.cc#newcode509
src/types.cc:509: PrintF(out, "Constant(0x%x)",
(unsigned)(*as_constant()));
Is there a specific reason you are not using %p (here and below)?
https://codereview.chromium.org/18587007/diff/23001/src/types.cc#newcode517
src/types.cc:517: if (i>0) PrintF(out, ",");
Nit: spaces around >
https://codereview.chromium.org/18587007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
