https://chromiumcodereview.appspot.com/22795004/diff/1/include/v8.h
File include/v8.h (right):
https://chromiumcodereview.appspot.com/22795004/diff/1/include/v8.h#newcode486
include/v8.h:486: template<class S>
On 2013/08/13 06:11:18, Sven Panne wrote:
Why do we have a separate template parameter here? As it is, this
signature
tells me: "It is OK to put any kind of value into an Eternal<T>, not
just Ts." I
don't think this is right...
As discussed offline, TYPE_CHECK is in implementation
https://chromiumcodereview.appspot.com/22795004/diff/1/src/api.cc
File src/api.cc (right):
https://chromiumcodereview.appspot.com/22795004/diff/1/src/api.cc#newcode679
src/api.cc:679: void V8::Eternalize(i::Isolate* isolate, i::Object**
handle, int* index) {
On 2013/08/12 15:13:13, rossberg wrote:
Is there a reason for changing this? I'd keep the functional version
if
possible.
The assertion that you're not reinitializing an eternal is in Create().
https://chromiumcodereview.appspot.com/22795004/diff/1/test/cctest/test-global-handles.cc
File test/cctest/test-global-handles.cc (right):
https://chromiumcodereview.appspot.com/22795004/diff/1/test/cctest/test-global-handles.cc#newcode521
test/cctest/test-global-handles.cc:521: // Create an eternal with via
the constructor
On 2013/08/12 15:13:13, rossberg wrote:
Nit: typo?
fixed
https://chromiumcodereview.appspot.com/22795004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
