LGTM with a nit.
https://chromiumcodereview.appspot.com/22795004/diff/9001/include/v8.h
File include/v8.h (right):
https://chromiumcodereview.appspot.com/22795004/diff/9001/include/v8.h#newcode5686
include/v8.h:5686:
V8::Eternalize(reinterpret_cast<internal::Isolate*>(isolate),
I think it would be nicer if we could do all this ugly casting in the
actual implementation (i.e. V8::Eternalize in the case at hand), unless
we have a very strong reason to do it in the header (which is not the
case here).
I know that we already do this at tons of places in v8.h, but it is
conceptually ugly as hell and destroys any kind of layering.
https://chromiumcodereview.appspot.com/22795004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
