On 2013/08/20 12:07:36, Yury Semikhatsky wrote:
On 2013/08/20 11:58:56, Benedikt Meurer wrote:
> What's the benefit of this change, other than trying to somehow unify the
code
> paths?

Just unification of the code no obvious performance gains at the moment. After
this change all but Windows port use the same mechanism based on signals.

Well previously Mac and Windows ports were using the same mechanism and everyone
else was using signals because of the lack of thread_suspend/resume.

Personally I think the thread_suspend/resume approach is cleaner and less likely to break compared to the SIGPROF approach, so I'm not in favor of using signals
on the Mac unless there's a good reason to do so.

https://chromiumcodereview.appspot.com/23115005/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to