Thanks Sven and tfarina.

Sure thing, as I mentioned in the initial message,
https://codereview.chromium.org/23480031/ shows the first intended use of this
flag. I envisage quite a few more, for example, reducing the amount of code
inlining, changing the parameters which decide between expanding the heap or
performing GC to prefer GC on memory constrained devices, changing the amount by which the heap is expanded (e.g., expand by 256KB rather than 1MB each time to have more granularity), and tweaking the max_heap default parameters based on the flag. I'll have to investigate these first before I can work out whether
they will be worth it though.


https://codereview.chromium.org/23464022/diff/1/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/23464022/diff/1/src/isolate.h#newcode1141
src/isolate.h:1141: bool isMemoryConstrained() {
On 2013/09/04 07:25:45, Sven Panne wrote:
On 2013/09/03 19:39:18, tfarina wrote:
> I believe this should be is_memory_constrained()

... and should be const.

Done.

https://codereview.chromium.org/23464022/diff/1/src/isolate.h#newcode1144
src/isolate.h:1144: void setIsMemoryConstrained(bool value) {
On 2013/09/03 19:39:18, tfarina wrote:
set_is_memory_constrained

Done.

https://codereview.chromium.org/23464022/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to