https://codereview.chromium.org/24269003/diff/12001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/24269003/diff/12001/src/api.cc#newcode636
src/api.cc:636: bool ConfigureResourceConstraintsForCurrentPlatform(
We had another discussion about that function right now... can we move
it to a separate file like v8-defaults.h? Adding it to the api is
problematic for many reasons, e.g., it hard to get rid of stuff added to
the api.
https://codereview.chromium.org/24269003/diff/12001/src/api.cc#newcode641
src/api.cc:641:
Please add a comment which specifies the given configuration values,
e.g., young space has to be a power of 2 and old space has to be a
multiple of Page::kPageSize.
https://codereview.chromium.org/24269003/diff/12001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/24269003/diff/12001/src/heap.cc#newcode72
src/heap.cc:72: #if V8_TARGET_ARCH_X64
Let's get rid of this ifdef as well and use kPointerSize for the default
calculation below.
https://codereview.chromium.org/24269003/diff/12001/src/heap.cc#newcode74
src/heap.cc:74: code_range_size_(512*MB),
Can we specify that in ConfigureResourceConstraintsForCurrentPlatform as
well?
https://codereview.chromium.org/24269003/diff/12001/src/heap.cc#newcode83
src/heap.cc:83: max_executable_size_(256l * LUMP_OF_MEMORY),
indent
https://codereview.chromium.org/24269003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
