https://codereview.chromium.org/24269003/diff/18001/src/globals.h
File src/globals.h (right):
https://codereview.chromium.org/24269003/diff/18001/src/globals.h#newcode251
src/globals.h:251: const bool kIs64BitArch = true;
On 2013/09/24 13:43:44, Hannes Payer wrote:
I think these two constants are not used anymore.
It's used for the code_range_size_ in heap.cc. I can change that to use
(kPointerSize == 8) if you prefer, but I think kIs64BitArch is clearer.
WDYT?
https://codereview.chromium.org/24269003/diff/18001/src/platform-posix.cc
File src/platform-posix.cc (right):
https://codereview.chromium.org/24269003/diff/18001/src/platform-posix.cc#newcode105
src/platform-posix.cc:105: uintptr_t OS::TotalPhysicalMemory() {
On 2013/09/24 13:47:15, Benedikt Meurer wrote:
Shouldn't this return an uint64_t? Otherwise this is going to break in
32-bit
mode applications on a 64-bit machine with more than 4 GiB of RAM,
right? Did
you actually test this?
You're right. For some reason I thought a uintptr_t would be a uint64_t
on 64bit machines. I did test ia32, but the truncation ended up leaving
2GB so I didn't notice it was truncated.
Done.
https://codereview.chromium.org/24269003/diff/18001/src/platform-posix.cc#newcode116
src/platform-posix.cc:116: return static_cast<uintptr_t> size;
On 2013/09/24 13:47:15, Benedikt Meurer wrote:
This static_cast is missing parenthesis.
Done.
https://codereview.chromium.org/24269003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
