On 2013/09/25 12:10:44, rmcilroy wrote:
On 2013/09/24 15:32:15, Hannes Payer wrote:
> https://codereview.chromium.org/24269003/diff/18001/src/globals.h
> File src/globals.h (right):
>
>
https://codereview.chromium.org/24269003/diff/18001/src/globals.h#newcode251
> src/globals.h:251: const bool kIs64BitArch = true;
> On 2013/09/24 14:39:23, rmcilroy wrote:
> > On 2013/09/24 13:43:44, Hannes Payer wrote:
> > > I think these two constants are not used anymore.
> >
> > It's used for the code_range_size_ in heap.cc. I can change that to
use
> > (kPointerSize == 8) if you prefer, but I think kIs64BitArch is
clearer.
WDYT?
>
> Ah, yes. Hmm, let's keep the kIs64BitArch constant. That's cleaner.
Cool, thanks.
Benedikt: any further comments for the platform code?
Danno: could you give this a final LGTM if you're happy with it since
Benedikt
is on vacation.
https://codereview.chromium.org/24269003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
