looks sane
https://codereview.chromium.org/116533003/diff/20001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/116533003/diff/20001/src/runtime.cc#newcode5733
src/runtime.cc:5733: if (!constructor->IsJSFunction()) {
nit. v8 style is if (...) return false; (in one line). if it doesn't fit
in one line, but the body is just one line, no need for { }
https://codereview.chromium.org/116533003/diff/20001/src/runtime.cc#newcode5740
src/runtime.cc:5740: return constructor_fun->shared()->
nit the -> should go on the next line
https://codereview.chromium.org/116533003/diff/20001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/116533003/diff/20001/test/cctest/test-api.cc#newcode10009
test/cctest/test-api.cc:10009: Local<v8::FunctionTemplate> t1 =
v8::FunctionTemplate::New();
please pass an isolate to ::New (here and below)
https://codereview.chromium.org/116533003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
