https://codereview.chromium.org/116533003/diff/120001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/116533003/diff/120001/src/runtime.cc#newcode5808
src/runtime.cc:5808: if (i > 0 && jsproto->map()->is_hidden_prototype())
{
On 2013/12/26 13:26:58, dcarney wrote:
this should just be i > 0
Done.
https://codereview.chromium.org/116533003/diff/120001/src/runtime.cc#newcode5815
src/runtime.cc:5815: RUNTIME_ASSERT(names->get(j)->IsString());
On 2013/12/24 08:48:08, dcarney wrote:
I don't think these asserts are necessary, but the correct assert
would be
IsName(), since this function supports returning symbols as well as
strings.
also, an ASSERT would make more sense here
Gone; I kept the use of String (rather than Name.)
https://codereview.chromium.org/116533003/diff/120001/src/runtime.cc#newcode5842
src/runtime.cc:5842: if (proto_with_hidden_properties > 0 || duplicates
0) {
On 2013/12/26 13:26:58, dcarney wrote:
actually, a better solution might be to call this unified variable
hidden_strings and insert the hidden string above instead of the hole.
it would
reduce complexity
Nice redux; done.
https://codereview.chromium.org/116533003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
