On 2014/02/05 11:10:51, Michael Achenbach wrote:
Comment on the concept: Are the MIPS port CLs always unique? What happens
if
you
commit a MIPS port for a CL and later realize that you made a mistake and
need
to add something in a follow up CL? How is the naming convention of the
follow
up CL?
Of course, if we'd get some of the MIPS CLs automatically but miss a few,
it
would already be an improvement.
Note: I am working on a python port for this script (low prio though).
Code comments:
https://codereview.chromium.org/152343011/diff/1/tools/merge-to-branch.sh
File tools/merge-to-branch.sh (right):
https://codereview.chromium.org/152343011/diff/1/tools/merge-to-branch.sh#newcode144
tools/merge-to-branch.sh:144: MIPS_GIT_HASH=$(git log svn/bleeding_edge -1
--format=%H --grep="Port r$REVISION")
Can svn/bleeding_edge be left out here?
https://codereview.chromium.org/152343011/diff/1/tools/merge-to-branch.sh#newcode145
tools/merge-to-branch.sh:145: if [ "$MIPS_GIT_HASH" != "" ] ; then
I'm not a bash expert. Is this equivalent? Then prefer the latter for
consistency:
if [ "$MIPS_GIT_HASH" != "" ] ; then
if [ -n "$MIPS_GIT_HASH" ] ; then
https://codereview.chromium.org/152343011/diff/1/tools/merge-to-branch.sh#newcode148
tools/merge-to-branch.sh:148:
FULL_REVISION_LIST=("${FULL_REVISION_LIST[@]}"
"$REVISION" "$MIPS_SVN_REVISION")
What is with revisions where no MIPS port exists, are they skipped now?
E.g.
consider 3 revision to be merged out of which two have a MIPS port. Where
is
the
third added to FULL_REVISION_LIST?
https://codereview.chromium.org/152343011/diff/1/tools/merge-to-branch.sh#newcode179
tools/merge-to-branch.sh:179: for REVISION in $FULL_REVISION_LIST ; do
All state that needs to be transferred from one step to the next should be
persisted. E.g. if "git svn find-rev" times out in this step, the script
should
be callable with the -s option in the same step, where it failed. Look
below
how
REVISION_LIST is persisted.
Currently we don't have a naming convention for the follow up fixes,
however if
we also tag these commits with "Port rXXX" in the future, then the new
script
can also cherry-pick these in the correct (date) order. Thanks for the idea!
https://codereview.chromium.org/152343011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
