Thanks, I've addressed your comments.
https://codereview.chromium.org/152343011/diff/70001/tools/merge-to-branch.sh
File tools/merge-to-branch.sh (right):
https://codereview.chromium.org/152343011/diff/70001/tools/merge-to-branch.sh#newcode152
tools/merge-to-branch.sh:152: while read -r NEXT_GIT_HASH; do
On 2014/02/06 09:30:26, Jakob wrote:
for consistency with other loops, can we just use:
for NEXT_GIT_HASH in $GIT_HASHES; do
...
done
or does the while loop provide any particular benefit?
The problem here is that the "git log" command returns a newline
separated list, which can't be iterated with the for loop with the
default IFS value. Of course, if I change IFS to IFS=$'\n' then the for
loop can split the string correctly. However, I think that using the
while loop is a cleaner way then changing the IFS variable.
https://codereview.chromium.org/152343011/diff/70001/tools/merge-to-branch.sh#newcode188
tools/merge-to-branch.sh:188: for REVISION in $FULL_REVISION_LIST ; do
On 2014/02/06 09:30:26, Jakob wrote:
Before using this variable in a new step, please add:
restore_if_unset "FULL_REVISION_LIST"
Thanks, done.
https://codereview.chromium.org/152343011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
