Looks good overall to me, just one minor suggestion.

https://codereview.chromium.org/164793003/diff/1/src/a64/macro-assembler-a64.cc
File src/a64/macro-assembler-a64.cc (right):

https://codereview.chromium.org/164793003/diff/1/src/a64/macro-assembler-a64.cc#newcode5178
src/a64/macro-assembler-a64.cc:5178: include &= ~(xzr.Bit() |
csp.Bit());
Maybe add an assert here too to warn if someone tries to add them?

https://codereview.chromium.org/164793003/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to