https://codereview.chromium.org/164793003/diff/1/src/a64/macro-assembler-a64.cc
File src/a64/macro-assembler-a64.cc (right):
https://codereview.chromium.org/164793003/diff/1/src/a64/macro-assembler-a64.cc#newcode5178
src/a64/macro-assembler-a64.cc:5178: include &= ~(xzr.Bit() |
csp.Bit());
On 2014/02/20 13:06:00, rmcilroy wrote:
Maybe add an assert here too to warn if someone tries to add them?
My reasoning was that in several MacroAssembler operations, we can treat
the result as a scratch register (as long as it's not an input):
temps.Include(rd);
temps.Exclude(rn, rm);
However, rd can be csp in most cases. So as not to complicate the logic
in these operations, I thought it best to just ignore them, so we can do
temps.Include(rd) without having to check that it's not csp.
Note that I haven't actually made that optimisation; at the moment it
isn't necessary, and this patch is big enough already. Would you prefer
that I put the assertion in now, and then remove it later if necessary?
https://codereview.chromium.org/164793003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
