Looks much better to me, just a couple more small nits.
One thing - could you please send a message when you upload a new patch set
which you want me to review - I don't get a notification when you upload a
patch
set, just when you send me a message (and you sent you last message a few
hours
before uploading the patch-set).
https://codereview.chromium.org/164793003/diff/250001/src/a64/macro-assembler-a64.cc
File src/a64/macro-assembler-a64.cc (right):
https://codereview.chromium.org/164793003/diff/250001/src/a64/macro-assembler-a64.cc#newcode4828
src/a64/macro-assembler-a64.cc:4828:
ASSERT(!TmpList()->IncludesAliasOf(arg0));
nit -
ASSERT(!(TmpList()->IncludesAliasOf(arg0) ||
FPTmpList->IncludesAliasOf(arg0)))
etc.
https://codereview.chromium.org/164793003/diff/250001/src/a64/macro-assembler-a64.cc#newcode4984
src/a64/macro-assembler-a64.cc:4984: RegList old_fptmp_list =
FPTmpList()->list();
nit - old_fp_tmp_list (not old_fptmp_list)
https://codereview.chromium.org/164793003/diff/250001/src/a64/macro-assembler-a64.cc#newcode4996
src/a64/macro-assembler-a64.cc:4996: CPURegList fptmp_list =
kCallerSavedFP;
nit - fp_tmp_list (not fptmp_list)
https://codereview.chromium.org/164793003/diff/250001/src/a64/macro-assembler-a64.h
File src/a64/macro-assembler-a64.h (right):
https://codereview.chromium.org/164793003/diff/250001/src/a64/macro-assembler-a64.h#newcode2232
src/a64/macro-assembler-a64.h:2232: static void
ReleaseByCode(CPURegList* available, int code);
I don't think you need ReleaseByCode, ReleaseByRegList or
IncludeByRegList any more do you? Could you delete these please.
https://codereview.chromium.org/164793003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
